On Wed, May 12, 2021 at 09:56:31AM +0200, Heiner Kallweit wrote: > Which version is easier to read may be a question of personal taste. > Using the unaligned access helper in pci_vpd_read() was asked for by > Bjorn to complement a use of get_unaligned_le32() in pci_vpd_write(). > So I leave it up to him. Functionally it's the same anyway. get_unaligned_le32 and friends are really nice helpers, but only when they fit the use case. In this case the existing code is a fairly easy to follow loop, while the "new" version is a mess by all counts.
