On 12.05.2021 09:21, Christoph Hellwig wrote: > On Mon, May 10, 2021 at 09:09:02AM +0200, Heiner Kallweit wrote: >> len can have any value 1 .. 4. Also the proposal doesn't consider >> the skip value. > > So what about just keeping the code as-is then? The existing version > is much easier to read than the new one, has less branching and doesn't > use an obscure API thast should not generally be used in driver code. > Which version is easier to read may be a question of personal taste. Using the unaligned access helper in pci_vpd_read() was asked for by Bjorn to complement a use of get_unaligned_le32() in pci_vpd_write(). So I leave it up to him. Functionally it's the same anyway.
