Re: [PATCH] PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

[...]
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.

Just to add, the devm_ioremap_resource() internally calls
__devm_ioremap_resource() which is where error checking
and handling is actually having place.

> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Erkun Yang<yangerkun@xxxxxxxxxx>

A space is missing just before the e-mail port of the
"Signed-off-by", you might need to correct this.

Otherwise,

Reviewed-by: Krzysztof Wilczyński <kw@xxxxxxxxx>

Krzysztof



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux