devm_ioremap_resource() internally calls __devm_ioremap_resource() which is where error checking and handling is actually having place. So the dev_err in xgene_msi_probe() seems redundant and remove it. Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> Reviewed-by: Krzysztof Wilczyński <kw@xxxxxxxxx> Signed-off-by: ErKun Yang <yangerkun@xxxxxxxxxx> --- drivers/pci/controller/pci-xgene-msi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c index 1c34c897a7e2..369b50f626fd 100644 --- a/drivers/pci/controller/pci-xgene-msi.c +++ b/drivers/pci/controller/pci-xgene-msi.c @@ -451,7 +451,6 @@ static int xgene_msi_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); xgene_msi->msi_regs = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(xgene_msi->msi_regs)) { - dev_err(&pdev->dev, "no reg space\n"); rc = PTR_ERR(xgene_msi->msi_regs); goto error; } -- 2.25.4