On Tue, 2020-11-03 at 13:38 -0600, Bjorn Helgaas wrote:
> On Mon, Nov 02, 2020 at 03:57:12PM -0500, Jim Quinlan wrote:
> > The variable 'tmp' is used multiple times in the brcm_pcie_setup()
> > function. One such usage did not initialize 'tmp' to the current value of
> > the target register. By luck the mistake does not currently affect
> > behavior; regardless 'tmp' is now initialized properly.
>
> This is so trivial that there's probably no reason to post this again,
> but if you post a v2 for some reason, please update the subject to
> match the convention ("PCI: brcmstb: Verb ..."), e.g.,
>
> PCI: brcmstb: Initialize "tmp" before use
>
> The commit log does not say what the patch does, leaving it to the
> reader to infer it.
>
> Lorenzo will likely fix this up when he applies it.
>
> Incidental curiosity: where should I look to see what
> u32p_replace_bits() does? "git grep u32p_replace_bits" shows several
> calls, but no definitions.
It's a bunch if defines in 'include/linux/bitfield.h'
Regards,
Nicolas
Attachment:
signature.asc
Description: This is a digitally signed message part
