Hi Bjorn On Fri, Sep 25, 2020 at 04:01:38PM -0700, Ashok Raj wrote: > When Mechanical Retention Lock (MRL) is present, Linux doesn't process > those change events. > > The following changes need to be enabled when MRL is present. > > 1. Subscribe to MRL change events in SlotControl. > 2. When MRL is closed, > - If there is no ATTN button, then POWER on the slot. > - If there is ATTN button, and an MRL event pending, ignore > Presence Detect. Since we want ATTN button to drive the > hotplug event. > Did you get a chance to review this? Thought i'll just check with you. Seems like there was a lot happening in the error handling and hotplug side, I thought you might have wanted to wait for the dust to settle :-) > > Signed-off-by: Ashok Raj <ashok.raj@xxxxxxxxx> > Co-developed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> > --- > drivers/pci/hotplug/pciehp.h | 1 + > drivers/pci/hotplug/pciehp_ctrl.c | 69 +++++++++++++++++++++++++++++++++++++++ > drivers/pci/hotplug/pciehp_hpc.c | 27 ++++++++++++++- > 3 files changed, 96 insertions(+), 1 deletion(-) >