On Thu, Nov 04, 2010 at 12:27:07PM -0600, Milton Miller wrote: > On 2010-11-04 at about 14:31:30 Jiri Slaby wrote: > > Stanse found that when pdev is found and has no driver a reference is > > leaked in pcifront_common_process. So add pci_dev_put there. For the > > pdev == NULL case, pci_dev_put(NULL) is fine. > > While that may be true, the dev_err(&pcidev->dev ... is a NULL pointer > deref. I've put the fix in the branch (stable/xen-pcifront-fixes) that I will ask Linus to pull.. but what options did you need to find this? I tried to run this before putting your and Milton fix in: konrad@phenom:~/tar/stanse-1.1.2$ java -jar ./stanse.jar ~/work/linux/drivers/pci/xen-pcifront.c Stanse version "1.1.2" Copyright (c) 2008-2010 Masaryk University, Brno STANSE_HOME not specified. Using the location of stanse.jar. Checking for bugs: <-> File: /home/konrad/work/linux/drivers/pci/xen-pcifront.c <-> -------------------------------- Done. And no warnings? -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
