Michael Ellerman wrote: > On Mon, 2010-10-25 at 16:25 -0700, David Miller wrote: > > From: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx> > > Date: Mon, 25 Oct 2010 23:38:53 +0100 > > > > > David Miller wrote: > > >> From: Somnath Kotur <somnath.kotur@xxxxxxxxxx> > > >> Date: Mon, 25 Oct 2010 16:42:35 +0530 > > >> > > >> > By default, be2net uses MSIx wherever possible. > > >> > Adding a module parameter to use INTx for users who do not want to use MSIx. > > >> > > > >> > Signed-off-by: Somnath Kotur <somnath.kotur@xxxxxxxxxx> > > >> > > >> Either add a new ethtool flag, or use the PCI subsystem facilities > > >> for tweaking things to implement this. > > >> > > >> Do not use a module option, otherwise every other networking driver > > >> author will get the same "cool" idea, give the module option > > >> different names, and the resulting user experience is terrible. > > > > > > This has already happened, sadly. So far as I can see it's mostly done > > > to allow users to work around systems with broken MSIs; I'm not aware of > > > any other reason to prefer legacy interrupts. However, the PCI subsystem > > > already implements a blacklist and a kernel parameter for disabling MSIs > > > on these systems. > > > > The PCI subsystem bits I'm totally fine with. > > > > But in the drivers themselves, that's what I don't want. > > That horse has really really bolted, it's gawn. > > I count 26 drivers with "disable MSI/X" parameters. Some even have more > than one. > > 11 of them are network drivers, 9 scsi, 3 ata. > > I agree it's a mess for users, but it's probably preferable to a > non-working driver. > > Ethtool would be nice, but only for network drivers. Is there a generic > solution, quirks are obviously not keeping people happy. Since this is (normally) a property of the system, pci=nomsi is the generic solution. [...] > Misc: > sound/pci/hda/hda_intel.c:MODULE_PARM_DESC(enable_msi, "Enable Message Signaled Interrupt (MSI)"); > drivers/message/fusion/mptbase.c:MODULE_PARM_DESC(mpt_msi_enable_spi, " Enable MSI Support for SPI \ > drivers/message/fusion/mptbase.c:MODULE_PARM_DESC(mpt_msi_enable_fc, " Enable MSI Support for FC \ > drivers/message/fusion/mptbase.c:MODULE_PARM_DESC(mpt_msi_enable_sas, " Enable MSI Support for SAS \ > drivers/net/myri10ge/myri10ge.c:MODULE_PARM_DESC(myri10ge_msi, "Enable Message Signalled Interrupts"); [...] drivers/net/sfc/efx.c:MODULE_PARM_DESC(interrupt_mode, drivers/net/sfc/efx.c- "Interrupt mode (0=>MSIX 1=>MSI 2=>legacy)"); Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
