David Miller wrote: > From: Somnath Kotur <somnath.kotur@xxxxxxxxxx> > Date: Mon, 25 Oct 2010 16:42:35 +0530 > > > By default, be2net uses MSIx wherever possible. > > Adding a module parameter to use INTx for users who do not want to use MSIx. > > > > Signed-off-by: Somnath Kotur <somnath.kotur@xxxxxxxxxx> > > Either add a new ethtool flag, or use the PCI subsystem facilities > for tweaking things to implement this. > > Do not use a module option, otherwise every other networking driver > author will get the same "cool" idea, give the module option > different names, and the resulting user experience is terrible. This has already happened, sadly. So far as I can see it's mostly done to allow users to work around systems with broken MSIs; I'm not aware of any other reason to prefer legacy interrupts. However, the PCI subsystem already implements a blacklist and a kernel parameter for disabling MSIs on these systems. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html