On Tue, 22 Jun 2010, Rafael J. Wysocki wrote: > On Monday, June 21, 2010, Alan Stern wrote: > > This patch (as1402) fixes a bug in the PCI core. When a device is > > about to be suspended, the core does a runtime resume because the > > device settings may need to be reconfigured. But calling > > pm_runtime_resume() is not the right way to do this, because it does > > nothing to prevent the device from autosuspending immediately > > afterward. The core needs to use pm_runtime_get_sync() and > > pm_runtime_put_sync() instead. > > No, it doesn't need to, becuase the PM core has already called > pm_runtime_get_noresume() for the device (look into > drivers/base/power/main.c:dpm_prepare(), please). > > The patch is not necessary. Oops, you're absolutely right. I retract the patch. Sorry about that. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
