Re: [PATCH] PCI: use pm_runtime_get_sync during system suspend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday, June 21, 2010, Alan Stern wrote:
> This patch (as1402) fixes a bug in the PCI core.  When a device is
> about to be suspended, the core does a runtime resume because the
> device settings may need to be reconfigured.  But calling
> pm_runtime_resume() is not the right way to do this, because it does
> nothing to prevent the device from autosuspending immediately
> afterward.  The core needs to use pm_runtime_get_sync() and
> pm_runtime_put_sync() instead.

No, it doesn't need to, becuase the PM core has already called
pm_runtime_get_noresume() for the device (look into
drivers/base/power/main.c:dpm_prepare(), please).

The patch is not necessary.

> Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> CC: Rafael J. Wysocki <rjw@xxxxxxx>

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux