On Wednesday 21 April 2010 04:33:28 pm H. Peter Anvin wrote: > Do you have opinions on patches 1-2 of the series? > > I'm getting concerned about how the size of the patchset has grown, and > we're past -rc5 already... but it is a regression so we can't just defer > it to .35. Part 1: the essential part of this seems to be the trim_bios_range() change, and that part is not too big. In v4, Yinghai also removed probe_roms_32.c. That sounds like the right thing to do, but I'd rather have that in separate patch so it doesn't obfuscate the other change, and I don't know whether it *has* to be done for .34; maybe it could be deferred. Part 2: IMHO, we're putting way too much crap in kernel/resource.c. A name like "reserve_region_with_split_check_child()" is a pretty good clue that we've lost our way somewhere. But that's mostly a cosmetic thing, and the end result does seem to be something that fixes the current regression. So I guess that in spite of my issues with the implementation, I'm still OK with the concept. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
