On Wednesday 21 April 2010 10:45:46 am Yinghai Lu wrote: > On 04/21/2010 08:21 AM, Bjorn Helgaas wrote: > > Why are you doing this patch? Did you see a machine where the host > > bridge was left with no resources because of _CRS issues? If so, > > this patch feels like a band-aid. I'd rather investigate the issue > > directly, because that would probably be a Linux problem we could fix. > > > > Also, if there *is* a reported problem, you should include a link to > > the bugzilla or email thread. > > > No, just code review. In that case, I don't think this patch is a good idea. Assume we have a Linux problem with _CRS parsing, and as a result, we don't find any host bridge resources. This patch will cause us to silently revert to the default resources, so we lose the opportunity to debug and fix the Linux problem. Even worse, if there's a *BIOS* problem with _CRS, this patch will hide it and make it harder to diagnose. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
