(2010/04/08 11:32), Kenji Kaneshige wrote:
> Hidetoshi Seto wrote:
>> @@ -248,11 +248,13 @@ added:
>> /**
>> * find_source_device - search through device hierarchy for source
>> device
>> * @parent: pointer to Root Port pci_dev data structure
>> - * @err_info: including detailed error information such like id
>> + * @e_info: including detailed error information such like id
>> *
>> - * Invoked when error is detected at the Root Port.
>> + * Return 1 if found, otherwise 0.
>> + *
>> + * Invoked by DPC when error is detected at the Root Port.
>> */
>> -static void find_source_device(struct pci_dev *parent,
>> +static int find_source_device(struct pci_dev *parent,
>> struct aer_err_info *e_info)
>> {
>> struct pci_dev *dev = parent;
>
> I think we should bool instead of int.
Certainly. I'll fix.
> By the way, find_source_device() depends on the fact that
> e_info->error_dev_num is cleared by the caller.
> I'm a little worrying about this implementation. It is
> regardless of your change though.
Yeah, I can see.
The struct aer_err_info is trouble because it is often
reused everywhere. I should rework the struct too...
Thanks,
H.Seto
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
