(2010/04/08 11:17), Kenji Kaneshige wrote:
> Hidetoshi Seto wrote:
>> @@ -628,12 +628,12 @@ void aer_enable_rootport(struct aer_rpc *rpc)
>> }
>>
>> /**
>> - * disable_root_aer - disable Root Port's interrupts when receiving
>> messages
>> + * aer_disable_rootport - disable Root Port's interrupts when
>> receiving messages
>> * @rpc: pointer to a Root Port data structure
>> *
>> * Invoked when PCIe bus unloads AER service driver.
>> */
>> -static void disable_root_aer(struct aer_rpc *rpc)
>> +void aer_disable_rootport(struct aer_rpc *rpc)
>> {
>> struct pci_dev *pdev = rpc->rpd->port;
>> u32 reg32;
>
> It seems no one other than aer_remove() calls this function.
> So let's move it to aerdrv.c and make it static function.
Make sense.
Though I don't know why functions are populated like this,
yes, we can move aer_{en,dis}able_rootport() to aerdrv.c and
make them static.
It will be better to have an another patch to do so.
I'll include such patch in next post.
Thanks,
H.Seto
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
