On Wed, 2009-12-16 at 14:01 -0800, Jesse Barnes wrote:
> > Olof, once that's in you should be able to remove the hack you have in
> > the PA-Semi code to work around this.
> >
>
> Oops, looks like this fails for the modular case? I get an unresolved
> symbol error when building this with my default config...
>
> Care to resend with the fix against my for-linus branch?
Care to send a log ? I fail to see where the problem is since the patch
has:
--- linux-work.orig/drivers/pci/pci.c 2009-12-09 17:33:24.000000000 +1100
+++ linux-work/drivers/pci/pci.c 2009-12-09 17:34:16.000000000 +1100
@@ -2723,6 +2723,11 @@ int __attribute__ ((weak)) pci_ext_cfg_a
return 1;
}
+void __weak pci_fixup_cardbus(struct pci_bus *bus)
+{
+}
+EXPORT_SYMBOL(pci_fixup_cardbus);
Or is that broken in some way ?
I'm starting to regret trying to use weak stuff :-) I may turn it into a good
old:
#ifndef pcibios_fixup_cardbus
static inline void pcibios_fixup_cardbus(struct pci_bus *bus) { }
#define pcibios_fixup_cardbus
#endif
In a header and have ppc define it.
(And call it pcibios_ instead of pci_ which matches better what other arch
fixups are called :-)
Cheers,
Ben.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
