On Wed, 09 Dec 2009 17:52:13 +1100 Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote: > The cardbus code creates PCI devices without ever going through the > necessary fixup bits and pieces that normal PCI devices go through. > > There's in fact a commented out call to pcibios_fixup_bus() in there, > it's commented because ... it doesn't work. > > I could make pcibios_fixup_bus() do the right thing on powerpc easily > but I felt it cleaner instead to provide a specific hook > pci_fixup_cardbus for which a weak empty implementation is provided > by the PCI core. > > This fixes cardbus on powerbooks and probably all other PowerPC > platforms which was broken completely for ever on some platforms and > since 2.6.31 on others such as PowerBooks when we made the DMA ops > mandatory (since those are setup by the fixups). > > Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> > --- > > Note: In the long run we might want to streamline the hooks for fixing > up new devices vs. new busses and make some stuff common between > cardbus and PCI hotplug which is actually a mess. > > This is a quick fix that makes it work again in the meantime, and that > I would like to see in 2.6.31 and 2.6.32 stable at least. > > Another option if you prefer is I can make my pcibios_fixup_bus() do > the right thing in all cases I believe (by testing bus->is_added to > skip stuff that must not be done twice) and we can remove the comment > and stick the call in #ifdef CONFIG_PPC but I felt that solution was > a tad cleaner. > > Olof, once that's in you should be able to remove the hack you have in > the PA-Semi code to work around this. > Oops, looks like this fails for the modular case? I get an unresolved symbol error when building this with my default config... Care to resend with the fix against my for-linus branch? Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
