Re: [PATCH 1/3] Fix updating of named attribute groups

[Tejun Heo <teheo@xxxxxxx>]

Hello,

Matthew Wilcox wrote:
>>> +	} else {
>>> +		sd = sysfs_get(kobj->sd);
>>> +	}
>> nitpick: the last braces aren't necessary.
> 
> But are more aesthetically pleasing.

Hmmm... indeed, CodingStyle says

  Do not unnecessarily use braces where a single statement will do.

  if (condition)
	  action();

  This does not apply if one branch of a conditional statement is a single
  statement. Use braces in both branches.

  if (condition) {
	  do_this();
	  do_that();
  } else {
	  otherwise();
  }

So, please ignore my previous nitpick.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html