Matthew Wilcox wrote: > + if (update) { > + sd = sysfs_get_dirent(kobj->sd, grp->name); > + if (!sd) > + return -ENOENT; > + } else { > + error = sysfs_create_subdir(kobj, grp->name, &sd); > + if (error) > + return error; > + sysfs_get(sd); > + } > + } else { > + sd = sysfs_get(kobj->sd); > + } nitpick: the last braces aren't necessary. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html