On Mon, 2009-10-26 at 21:30 +0100, Ingo Molnar wrote: > * Bjorn Helgaas <bjorn.helgaas@xxxxxx> wrote: > > > On Friday 23 October 2009 03:53:54 pm Ingo Molnar wrote: > > > > > > * Bjorn Helgaas <bjorn.helgaas@xxxxxx> wrote: > > > > > > > The current whitelist requires a kernel change for every machine that > > > > has MMCONFIG regions above 4GB, even if BIOS provides a correct MCFG > > > > table. > > > > > > > > This patch expands the whitelist to include machines with a rev 1 or > > > > newer MCFG table and a DMI_BIOS_DATE of 2010 or later. That way, we > > > > only need kernel changes for new machines that provide incorrect MCFG > > > > tables. > > > > > > Can we do 2009 perhaps? I suspect most of the newer machines get > > > this right. (if not then we have no reason to assume that 2010 will > > > be any better) > > > > I used 2010 because I'm not aware of any 2009 machines with MMCONFIG > > above 4GB, so using 2009 seemed to add risk without benefit. If there > > are 2009 machines in the field with junk in the upper 32 bits of the > > MMCONFIG address, this patch would break them. > > > > But I'm not opposed to using 2009 if you think that's worthwhile. > > 2010 is fine - i did not realize >4g mmconf address space is this > uncommon. > > ( Can we print a warning if we meet such a box with an earlier DMI date > perhaps? ) I think the warning is already there. unless you want to tweak the wording or something: + printk(KERN_ERR PREFIX "MCFG region for %04x:%02x-%02x at %#llx " + "is above 4GB, ignored\n", cfg->pci_segment, + cfg->start_bus_number, cfg->end_bus_number, cfg->address); + return -EINVAL; Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
