Minor comment: > +#ifdef DEBUG > + printk(KERN_DEBUG "%s\n", __func__); > +#endif You should just use 'dev_dbg() for any debugging statments like this. You can turn them on and off dynamically, and you get all of the proper device information as to what is going on automatically. Plus, there's no need for a #ifdef in the code, which is generally frowned apon in .c files. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
