Re: Add qword support to pciutils (Take 4)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

> This is a patch to add support for qword (64-bit) read/write to setpci. It
> would be really nice to get this into pciutils.

Unfortunately, the problem is a little bit more complex, because we want
to keep the ABI of the library stable. Our `u64' (which need not be exact
u64 in the current version) is used to define `pciaddr_t', which in turn
appears in `struct pci_dev'.

On the lucky side, there are no other occurrences of u64 in the API/ABI,
so as long as we keep the definition of pciaddr_t the same, we can change
u64 in any way we wish.

Could you please modify the patch to do that?

> * The types.h header changes needs to be scrutinizedi some more. Please
>   review those changes more closely.
>   - Does the QWORD define actually exist on MS Windows?

AFAIK it does not (I do not have a Windows system at hand, but Google has
revealed several implementations of <windef.h>, none of which defines QWORD.

				Have a nice fortnight
-- 
Martin `MJ' Mares                          <mj@xxxxxx>   http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
Press any key to quit or any other key to continue
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux