> From: Greg KH [mailto:greg@xxxxxxxxx] > Sent: Thursday, June 11, 2009 2:58 PM > To: Jesse Barnes > Cc: linux-pci@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx; Pan, Jacob jun > Subject: Re: [PATCH] x86/PCI: Intel Moorestown platform "PCI" support > > On Thu, Jun 11, 2009 at 02:23:11PM -0700, Jesse Barnes wrote: > > > +#if defined(CONFIG_X86_IO_APIC) && defined(CONFIG_SFI) > > + /* For platforms only have IOAPIC, the PCI irq line is 1:1 > > mapped to > > + * IOAPIC RTE entries, so we just enable RTE for the > > device. > > + */ > > + if (platform_has(X86_PLATFORM_FEATURE_IOAPIC) && > > + !platform_has(X86_PLATFORM_FEATURE_8259) && > > + !platform_has(X86_PLATFORM_FEATURE_ACPI) && > > + !platform_has(X86_PLATFORM_FEATURE_BIOS) && > > + pin) { > > + ioapic = mp_sfi_find_ioapic(dev->irq); > > + io_apic_set_pci_routing(ioapic, > > + dev->irq, /* IOAPIC pin */ > > + dev->irq, /* IRQ line */ > > + 1, /* level trigger */ > > + 1); /* polarity active low */ > > + } > > +#endif > > Does there really need to be a #ifdef here? Wouldn't the first > platform_has() catch things? And what is CONFIG_SFI? Hi Greg, SFI stands for Simple Firmware Interface, it is like a reduced subset of ACPI standards, whose main purpose is to pass platform system info like memory map/ ioapic/timer ... info to OS. It fits for simple handheld platform like Intel Moorestown platform. SFI supporting code is on the way to be submitted upstream, CONFIG_SFI is the option to enable the SFI support. Thanks, Feng > > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
