>-----Original Message----- >From: Greg KH [mailto:greg@xxxxxxxxx] >Sent: Thursday, June 11, 2009 2:58 PM >To: Jesse Barnes >Cc: linux-pci@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx; Pan, Jacob jun >Subject: Re: [PATCH] x86/PCI: Intel Moorestown platform "PCI" support > >On Thu, Jun 11, 2009 at 02:23:11PM -0700, Jesse Barnes wrote: >> --- a/arch/x86/pci/fixup.c >> +++ b/arch/x86/pci/fixup.c >> @@ -521,3 +521,13 @@ static void sb600_disable_hpet_bar(struct pci_dev *dev) >> } >> } >> DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_ATI, 0x4385, sb600_disable_hpet_bar); >> +/* Intel Moorestown graphics controller has new capabilities but the status >> + * register does not indicate that in bit 4. >> + */ >> +static void __devinit pci_mrst_gfx_controller_cap(struct pci_dev *dev) >> +{ >> + /* force new cap flag */ >> + pci_write_config_byte(dev, PCI_STATUS, PCI_STATUS_CAP_LIST); >> +} >> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MRST_GFX, >> + pci_mrst_gfx_controller_cap); > >As this is an "unreleased" chip, can't this be fixed up properly before >it ships? > [[JPAN]] I will work with the HW team to track the request. It was decided "not to fix" in the second stepping while the bug was found in the first stepping. > >> +#if defined(CONFIG_X86_IO_APIC) && defined(CONFIG_SFI) >> + /* For platforms only have IOAPIC, the PCI irq line is 1:1 mapped to >> + * IOAPIC RTE entries, so we just enable RTE for the device. >> + */ >> + if (platform_has(X86_PLATFORM_FEATURE_IOAPIC) && >> + !platform_has(X86_PLATFORM_FEATURE_8259) && >> + !platform_has(X86_PLATFORM_FEATURE_ACPI) && >> + !platform_has(X86_PLATFORM_FEATURE_BIOS) && >> + pin) { >> + ioapic = mp_sfi_find_ioapic(dev->irq); >> + io_apic_set_pci_routing(ioapic, >> + dev->irq, /* IOAPIC pin */ >> + dev->irq, /* IRQ line */ >> + 1, /* level trigger */ >> + 1); /* polarity active low */ >> + } >> +#endif > >Does there really need to be a #ifdef here? Wouldn't the first >platform_has() catch things? And what is CONFIG_SFI? > [[JPAN]] I agree, platform_has() check should be sufficient. Perhaps we should have a dummy io_apic_set_pci_routing() when CONFIG_X86_IO_APIC is not defined? SFI is the Simple Firmware Interface, it provides static system tables similar to ACPI. System devices such as APIC and timers are included in the SFI tables. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
