Re: JMicron SATA controller not available - bisected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Marc Dionne wrote:
With current git the SATA DVD writer on my system is no longer detected, and these errors show up:

pci 0000:05:00.0: BAR 2: can't allocate resource
pci 0000:05:00.0: BAR 3: can't allocate resource
ahci 0000:05:00.0: device not available because of BAR 2 [0x00-0x07] collisions

.. where 05:00.0 is this SATA controller where the DVD is plugged in:

05:00.0 SATA controller: JMicron Technologies, Inc. 20360/20363 Serial ATA Controller (rev 03)

This is an ICH10-based board that has the JMicron controller in addition to the onboard SATA. The drive works fine if plugged into one of the onboard ports, and also works fine with kernel 2.6.29 on the JMicron controller.

I bisected the problem down to this commit:
480b93b7837fb3cf0579a42f4953ac463a5b9e1e: PCI: centralize device setup code

Note that this worked with recent 2.6.30-rc kernels until I had to reset the board's CMOS, so a change in a BIOS setting was probably a trigger.

The problem may be caused by an one-line cleanup code in drivers/pci/probe.c:

        ...
        pci_read_config_dword(dev, PCI_CLASS_REVISION, &class);
        dev->revision = class & 0xff;
        class >>= 8;                                /* upper 3 bytes */
        dev->class = class;
        class >>= 8;
        ....
        /* Early fixups, before probing the BARs */
        pci_fixup_device(pci_fixup_early, dev);
-       class = dev->class >> 8;

I was thinking the last line is redundant and removed it in that commit, but apparently the dev->class is changed after the fixup.

Can you please put the line back and try the device again? I'll post a fix if it works.

Thanks,
Yu
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux