On Tue, Apr 28, 2009 at 12:36:06AM -0700, Yinghai Lu wrote: > > while looking dev_set_name() calling, there is one > dev_set_name(&dev->dev, NULL) > to used to try to free the device name, before kfree that device. What's wrong with that? > need to move the check for device_add in > | commit 8a577ffc75d9194fe8cdb7479236f2081c26ca1f > | Author: Kay Sievers <kay.sievers@xxxxxxxx> > | Date: Sat Apr 18 15:05:45 2009 -0700 > | > | driver: dont update dev_name via device_add path > from kobject_set_name_vargs to kobject_add_vargs instead. > > in kobject_set_name_vargs will check if fmt is NULL. > > actually we need to use dev_set_name(,NULL) later on failing path > and release to prevent leaking Are you sure? confused, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
