Re: [PATCH v3] Setup disabled bridges even if buses are added.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>:
> Thank you for your review.
> 
> 
> This patch setups disabled bridges even if buses have already been
> added.
> 
> pci_assign_unassigned_resources is called after buses are added.
> pci_assign_unassigned_resources calls pci_bus_assign_resources.
> pci_bus_assign_resources calls pci_setup_bridge to configure BARs of
> bridges.
> 
> Currently pci_setup_bridge returns immediately if the bus have already
> been added. So pci_assign_unassigned_resources can't configure BARs of
> bridge.
> 
> The patch fixes the issue.
> 
> On logical hot-add, we need to prevent the kernel from re-initializing
> bridges that have already been initialized. To achieve this,
> pci_setup_bridge returns immediately if the bridge have already been
> enabled.
> 
> We don't need to check whether the specified bus is a root bus or not.
> pci_setup_bridge is not called on a root bus, because a root bus does
> not have a bridge.
> 
> The patch adds a new helper function, pci_is_enabled. I made the
> function name similar to pci_is_managed. The codes which use
> enable_cnt directly are changed to use pci_is_enabled.
> 
> Thanks,
> --
> Yuji Shimada
 
Acked-by: Alex Chiang <achiang@xxxxxx>
 
> Signed-off-by: Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>
 
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux