Grant Grundler wrote:
On Mon, Feb 23, 2009 at 11:32:22AM +1100, Benjamin Herrenschmidt wrote:
On Sat, 2009-02-21 at 19:10 -0700, Grant Grundler wrote:
drivers/parisc code assumes the hard coded numbers.
I'm looking at drivers/parisc/lba_pci.c:lba_fixup_bus().
A bunch of archs do, we need to fix them :-)
Of course, and I'm willing to help fix them (it's generally trivial).
I'd like to avoid breaking them in the interim though.
If the enums are guaranteed to start at zero, should be fine.
Yes, it's guaranteed by ISO C standard 9899-1999:
"If the first enumerator has no =, the value of its enumeration constant
is 0. Each subsequent enumerator with no = defines its enumeration
constant as the value of the constant expression obtained by adding 1 to
the value of the previous enumeration constant."
Thanks,
Yu
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
