Thank you for the updated patch.
Reviewed-by: Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx>
Tested-by: Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx>
Thanks,
Kenji Kaneshige
Frank Seidel wrote:
> From: Frank Seidel <frank@xxxxxxxxxxx>
>
> According to kerneljanitors todo list all printk calls (beginning
> a new line) should have an according KERN_* constant.
> Those are the missing pieces here for the pci subsystem.
>
> Signed-off-by: Frank Seidel <frank@xxxxxxxxxxx>
> ---
> drivers/pci/hotplug/pciehp.h | 10 +++++-----
> drivers/pci/hotplug/shpchp.h | 10 +++++-----
> drivers/pci/intel-iommu.c | 2 +-
> 3 files changed, 11 insertions(+), 11 deletions(-)
>
> --- a/drivers/pci/intel-iommu.c
> +++ b/drivers/pci/intel-iommu.c
> @@ -1960,7 +1960,7 @@ static inline void iommu_prepare_isa(voi
> ret = iommu_prepare_identity_map(pdev, 0, 16*1024*1024);
>
> if (ret)
> - printk("IOMMU: Failed to create 0-64M identity map, "
> + printk(KERN_ERR "IOMMU: Failed to create 0-64M identity map, "
> "floppy might not work\n");
>
> }
> --- a/drivers/pci/hotplug/pciehp.h
> +++ b/drivers/pci/hotplug/pciehp.h
> @@ -46,10 +46,10 @@ extern int pciehp_force;
> extern struct workqueue_struct *pciehp_wq;
>
> #define dbg(format, arg...) \
> - do { \
> - if (pciehp_debug) \
> - printk("%s: " format, MY_NAME , ## arg); \
> - } while (0)
> +do { \
> + if (pciehp_debug) \
> + printk(KERN_DEBUG "%s: " format, MY_NAME , ## arg); \
> +} while (0)
> #define err(format, arg...) \
> printk(KERN_ERR "%s: " format, MY_NAME , ## arg)
> #define info(format, arg...) \
> @@ -60,7 +60,7 @@ extern struct workqueue_struct *pciehp_w
> #define ctrl_dbg(ctrl, format, arg...) \
> do { \
> if (pciehp_debug) \
> - dev_printk(, &ctrl->pcie->device, \
> + dev_printk(KERN_DEBUG, &ctrl->pcie->device, \
> format, ## arg); \
> } while (0)
> #define ctrl_err(ctrl, format, arg...) \
> --- a/drivers/pci/hotplug/shpchp.h
> +++ b/drivers/pci/hotplug/shpchp.h
> @@ -48,10 +48,10 @@ extern int shpchp_debug;
> extern struct workqueue_struct *shpchp_wq;
>
> #define dbg(format, arg...) \
> - do { \
> - if (shpchp_debug) \
> - printk("%s: " format, MY_NAME , ## arg); \
> - } while (0)
> +do { \
> + if (shpchp_debug) \
> + printk(KERN_DEBUG "%s: " format, MY_NAME , ## arg); \
> +} while (0)
> #define err(format, arg...) \
> printk(KERN_ERR "%s: " format, MY_NAME , ## arg)
> #define info(format, arg...) \
> @@ -62,7 +62,7 @@ extern struct workqueue_struct *shpchp_w
> #define ctrl_dbg(ctrl, format, arg...) \
> do { \
> if (shpchp_debug) \
> - dev_printk(, &ctrl->pci_dev->dev, \
> + dev_printk(KERN_DEBUG, &ctrl->pci_dev->dev, \
> format, ## arg); \
> } while (0)
> #define ctrl_err(ctrl, format, arg...) \
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
