From: Frank Seidel <frank@xxxxxxxxxxx> According to kerneljanitors todo list all printk calls (beginning a new line) should have an according KERN_* constant. Those are the missing pieces here for the pci subsystem. Signed-off-by: Frank Seidel <frank@xxxxxxxxxxx> --- drivers/pci/hotplug/pciehp_core.c | 6 +++--- drivers/pci/hotplug/shpchp_core.c | 4 ++-- drivers/pci/intel-iommu.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) --- a/drivers/pci/hotplug/pciehp_core.c +++ b/drivers/pci/hotplug/pciehp_core.c @@ -526,16 +526,16 @@ static int __init pcied_init(void) pciehp_firmware_init(); retval = pcie_port_service_register(&hpdriver_portdrv); - dbg("pcie_port_service_register = %d\n", retval); + dbg(KERN_DEBUG "pcie_port_service_register = %d\n", retval); info(DRIVER_DESC " version: " DRIVER_VERSION "\n"); if (retval) - dbg("Failure to register service\n"); + dbg(KERN_DEBUG "Failure to register service\n"); return retval; } static void __exit pcied_cleanup(void) { - dbg("unload_pciehpd()\n"); + dbg(KERN_DEBUG "unload_pciehpd()\n"); pcie_port_service_unregister(&hpdriver_portdrv); info(DRIVER_DESC " version: " DRIVER_VERSION " unloaded\n"); } --- a/drivers/pci/hotplug/shpchp_core.c +++ b/drivers/pci/hotplug/shpchp_core.c @@ -396,14 +396,14 @@ static int __init shpcd_init(void) int retval = 0; retval = pci_register_driver(&shpc_driver); - dbg("%s: pci_register_driver = %d\n", __func__, retval); + dbg(KERN_DEBUG "%s: pci_register_driver = %d\n", __func__, retval); info(DRIVER_DESC " version: " DRIVER_VERSION "\n"); return retval; } static void __exit shpcd_cleanup(void) { - dbg("unload_shpchpd()\n"); + dbg(KERN_DEBUG "unload_shpchpd()\n"); pci_unregister_driver(&shpc_driver); info(DRIVER_DESC " version: " DRIVER_VERSION " unloaded\n"); } --- a/drivers/pci/intel-iommu.c +++ b/drivers/pci/intel-iommu.c @@ -1960,7 +1960,7 @@ static inline void iommu_prepare_isa(voi ret = iommu_prepare_identity_map(pdev, 0, 16*1024*1024); if (ret) - printk("IOMMU: Failed to create 0-64M identity map, " + printk(KERN_ERR "IOMMU: Failed to create 0-64M identity map, " "floppy might not work\n"); } -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html