On Fri, 6 Feb 2009, Taku Izumi wrote: > Frank Seidel wrote: > > From: Frank Seidel <frank@xxxxxxxxxxx> > > > > According to kerneljanitors todo list all printk calls (beginning > > a new line) should have an according KERN_* constant. > > Those are the missing pieces here for the pci subsystem. > > > > Signed-off-by: Frank Seidel <frank@xxxxxxxxxxx> > > --- > > drivers/pci/hotplug/pciehp.h | 3 ++- > > drivers/pci/hotplug/shpchp.h | 3 ++- > > drivers/pci/intel-iommu.c | 2 +- > > 3 files changed, 5 insertions(+), 3 deletions(-) > > > > --- a/drivers/pci/intel-iommu.c > > +++ b/drivers/pci/intel-iommu.c > > @@ -1960,7 +1960,7 @@ static inline void iommu_prepare_isa(voi > > ret = iommu_prepare_identity_map(pdev, 0, 16*1024*1024); > > > > if (ret) > > - printk("IOMMU: Failed to create 0-64M identity map, " > > + printk(KERN_ERR "IOMMU: Failed to create 0-64M identity map, " > > "floppy might not work\n"); > > > > } > > --- a/drivers/pci/hotplug/pciehp.h > > +++ b/drivers/pci/hotplug/pciehp.h > > @@ -48,7 +48,8 @@ extern struct workqueue_struct *pciehp_w > > #define dbg(format, arg...) \ > > do { \ > > if (pciehp_debug) \ > > - printk("%s: " format, MY_NAME , ## arg); \ > > + printk(KERN_DEBUG "%s: " format, MY_NAME , \ > > + ## arg); \ > > } while (0) > > #define err(format, arg...) \ > > printk(KERN_ERR "%s: " format, MY_NAME , ## arg) > > Why didn't you retouch the following dev_printk ? > > #define ctrl_dbg(ctrl, format, arg...) \ > do { \ > if (pciehp_debug) \ > dev_printk(, &ctrl->pcie->device, \ > format, ## arg); \ > } while (0) That's almost the same as dev_dbg(), except for the test for pciehp_debug, for which you can probably get an alternative using CONFIG_DYNAMIC_PRINTK_DEBUG. With kind regards, Geert Uytterhoeven Software Architect Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@xxxxxxxxxxx Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010 -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html