Hi,
I have some minor comments below.
Frank Seidel wrote:
(snip.)
> --- a/drivers/pci/hotplug/pciehp.h
> +++ b/drivers/pci/hotplug/pciehp.h
> @@ -48,7 +48,8 @@ extern struct workqueue_struct *pciehp_w
> #define dbg(format, arg...) \
> do { \
> if (pciehp_debug) \
> - printk("%s: " format, MY_NAME , ## arg); \
> + printk(KERN_DEBUG "%s: " format, MY_NAME , \
> + ## arg); \
> } while (0)
How about below. I think we can write printk in one line.
#define dbg(format, arg...) \
do { \
if (pciehp_debug) \
printk(KERN_DEBUG "%s: " format, MY_NAME, ## arg); \
} while (0)
> #define err(format, arg...) \
> printk(KERN_ERR "%s: " format, MY_NAME , ## arg)
> --- a/drivers/pci/hotplug/shpchp.h
> +++ b/drivers/pci/hotplug/shpchp.h
> @@ -50,7 +50,8 @@ extern struct workqueue_struct *shpchp_w
> #define dbg(format, arg...) \
> do { \
> if (shpchp_debug) \
> - printk("%s: " format, MY_NAME , ## arg); \
> + printk(KERN_DEBUG "%s: " format, MY_NAME , \
> + ## arg); \
> } while (0)
Ditto.
Thanks,
Kenji Kaneshige
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
