On Tue, 20 Jan 2009, Mark Lord wrote: > Next, there's no mention of a need for invoking pci_intx() in the HOW-TO, > yet some device drivers call it, and others do not. Some devices don't work if you call it (don't send any interrupts); others don't work if you don't call it (send both types of interrupts); most don't care either way. In any case, the core code should deal with it based on quirks. I think there isn't any manufacturer who has had both kinds of quirk, and the clarified spec says that the INTX bit shouldn't matter when MSI is enabled, so manufacturers are slowly converging to that. Initially, the core didn't do anything, and some drivers implemented the need-intx-off quirk; eventually this went into the core as the default behavior. Then some drivers implemented the need-intx-on quirk. Then some common drivers for different hardware turned out to need it both ways, and the core got a real quirk for it. But not all of the drivers have dropped the local setting stuff. The right way to go is to do nothing in the driver and use quirks if you need it. -Daniel *This .sig left intentionally blank* -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
