Re: [PATCH] pci: detect and abort on 0 irq in AER driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 03, 2009 at 05:26:09PM +0100, Rafael J. Wysocki wrote:
> IMO, the entire handling of PCI Express port is overly complicated.  Namely,

I couldn't agree more.

> instead of having the pcie_port_bus_type (which is buggy at the moment, as
> described in http://marc.info/?l=linux-pci&m=123083608311844&w=4) it
> would be better to register port services directly within the port driver using
> a simple mechanism like an array (there are at most 4 services possible and
> we know exactly what they are).
> 
> I have an idea how to rework it, but first I'd like to know what your opinions
> are.

Yay.  I've wanted to fix this for about three years now.

> That said, I think the patch is fine anyway.

Yeah, this is a good fix for the problem that exists today.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux