>From 96cc66d7ebf9e55fe479cbae9f44619550758821 Mon Sep 17 00:00:00 2001 From: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> Date: Sat, 3 Jan 2009 07:53:55 -0800 Subject: [PATCH] pci: detect and abort on 0 irq in AER driver irq 0 is not a valid irq for AER reporting, however sometimes a system that doesn't really support AER lets this slip through. This patch aborts early rather than registering at this invalid interrupt (which also happens to be the timer interrupt, much fun could happen) As seen by kerneloops.org report 165038 Reported-by: kerneloops.org Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> --- drivers/pci/pcie/aer/aerdrv.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/pci/pcie/aer/aerdrv.c b/drivers/pci/pcie/aer/aerdrv.c index e390707..738563a 100644 --- a/drivers/pci/pcie/aer/aerdrv.c +++ b/drivers/pci/pcie/aer/aerdrv.c @@ -214,6 +214,13 @@ static int __devinit aer_probe (struct pcie_device *dev, struct aer_rpc *rpc; struct device *device = &dev->device; + /* + * If dev->irq is 0, then AER is not working, and we should bail out + * early. This has been seen in the wild via kerneloops.org. + */ + if (!dev->irq) + return -ENODEV; + /* Init */ if ((status = aer_init(dev))) return status; -- 1.6.0.6 -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
