Some BIOSes hide 'overflow' device (dev #6) for i82875P/PE chipsets. The same happens for i82865P/PE. Add a quirk to enable this device. This allows i82875 EDAC driver to bind to chipset's dev #6 and not dev #0 as the latter is used by AGP driver. This is rebased against 2.6.28 vanilla kernel, including trimming of long lines. After testing this patch for couple of days on my laptop (i82856P) it looks like something is resetting device 0 (MCH) config register 0xF4 to zero and effectively disabling the device again. The delay looks random to me. I can easily update the register using 'hexedit /sys/bus/pci/devices/0000\:00\:00.0/config' and see correct values in lspci output afterwards. This is probably BIOS's fault. This changes nothing as far as i82875P EDAC driver is concerned as it has the same assumption that BIOS is well behaved. In case some really broken BIOS is found, this can be wrapped around some new Kconfig #ifdef. Signed-off-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx> diff -urN a/drivers/pci/quirks.c b/drivers/pci/quirks.c --- a/drivers/pci/quirks.c 2008-10-10 00:13:53.000000000 +0200 +++ b/drivers/pci/quirks.c 2008-12-06 22:18:46.000000000 +0100 @@ -1946,6 +1947,27 @@ #endif /* CONFIG_PCI_MSI */ +/* Originally in EDAC sources for i82875P: + * Intel tells BIOS developers to hide device 6 which + * configures the overflow device access containing + * the DRBs - this is where we expose device 6. + * http://www.x86-secret.com/articles/tweak/pat/patsecrets-2.htm + */ +static void __devinit quirk_unhide_mch_dev6(struct pci_dev *dev) +{ + u8 reg; + + if (pci_read_config_byte(dev, 0xF4, ®) == 0 && !(reg & 0x02)) { + dev_info(&dev->dev, "Enabling MCH 'Overflow' Device\n"); + pci_write_config_byte(dev, 0xF4, reg | 0x02); + } +} + +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82865_HB, + quirk_unhide_mch_dev6); +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82875_HB, + quirk_unhide_mch_dev6); + static void pci_do_fixups(struct pci_dev *dev, struct pci_fixup *f, struct pci_fixup *end) { while (f < end) { -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
