Should we check dev->is_busmaster in pci_enable_{msi|msix}?

[Jike Song <albcamus@xxxxxxxxx>]

Hi all,

In the "PCI Express Base Rev 2.0", Section 7.5.1.1:

Bus Master Enable - {snip}
Note that as MSI/MSI-X interrupt Messages are in-band memory
writes, setting the Bus Master Enable bit to 0b disables
MSI/MSI-X interrupt Messages as well.

But we didn't check if bus-master is enabled when enabling
MSI/MSI-X, is this correct?  What will happen if a driver calls
pci_enable_msi without calling pci_set_master previously?

--
Thanks,
Jike

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html