Bjorn Helgaas <bjorn.helgaas@xxxxxx> wrote: > +/** > + * pci_swizzle_interrupt_pin - swizzle INTx for device behind bridge > + * @dev: the PCI device > + * @pin: the INTx pin (1=INTA, 2=INTB, 3=INTD, 4=INTD) > + * > + * The PCI-to-PCI bridge specification requires INTx swizzling for > + * devices behind bridges on add-in cards. This performs the swizzle > + * for one level of bridge. > + */ Better. > +u8 pci_swizzle_interrupt_pin(struct pci_dev *dev, u8 pin) > +{ > + /* This implements Table 9-1 of the PCI-to-PCI bridge spec */ I'd recommend merging this comment into the banner. > + return (((pin - 1) + PCI_SLOT(dev->devfn)) % 4) + 1; > +} > + David -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html