Bjorn Helgaas <bjorn.helgaas@xxxxxx> wrote: > > +u8 pci_swizzle_interrupt_pin(struct pci_dev *dev, u8 pin) > +{ > + /* This implements Table 9-1 of the PCI-to-PCI bridge spec */ > + return (((pin - 1) + PCI_SLOT(dev->devfn)) % 4) + 1; > +} > + Can you please add a banner comment to this function that gives at least a quick description of what this function is meant to do? Feel free to use kerneldoc. Saying table X of document Y isn't immediately helpful. David -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html