Re: [PATCH] pciaer: report config read/write errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/02/2008 02:44 PM, Stephen Hemminger wrote:
pci_find_ext_capability would succeed but all access to registers >= 256
would fail if MMCONFIG failed.



Your sentence seems self-contradicting to me. pci_find_ext_capability() (!= pci_find_capability()) only tries to access registers >= 256, so I don't see how it would succeed if *all* those accesses are failing.


P.s: you can look back into LKML for Linus discussion about why MMCONFIG
is broken anyway.



I was an active participant in one of those discussions (although it is possible I missed a later one), so I am quite aware about the limitations of MMCONFIG. But pci_find_ext_capability() looked to me a good filter to check about those limitations().

This is not just about pciaer, for instance, it might be that a lot of the SR-IOV code submitted recently assumes that if the corresponding extended-capability can be detected, little checking needs to be done afterwards.


Loic


--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux