Re: [PATCH 4/5] Add implementation of read_vpd() method for sysfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2008-11-17 at 21:50 +0100, Martin Mares wrote:
> Sharing a->fd for both file descriptors is ugly and it causes the sysfs file
> with configuration space to be reopened during a single run of lspci. Could
> you please add another member to struct pci_dev?

Using two separate fds would break the fudge used for pread()/pwrite()
on glibc 2.0 and earlier.  Maybe that can be removed now though?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux