Re: [PATCH 1/5] Add pci_read_vpd() function and internal read_vpd() method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2008-11-17 at 21:52 +0100, Martin Mares wrote:
> > index 8f4773f..deef985 100644
> > --- a/lib/pci.h
> > +++ b/lib/pci.h
> > @@ -144,6 +144,7 @@ u8 pci_read_byte(struct pci_dev *, int pos) PCI_ABI; /* Access to configuration
> >  u16 pci_read_word(struct pci_dev *, int pos) PCI_ABI;
> >  u32 pci_read_long(struct pci_dev *, int pos) PCI_ABI;
> >  int pci_read_block(struct pci_dev *, int pos, u8 *buf, int len) PCI_ABI;
> > +int pci_read_vpd(struct pci_dev *d, int pos, u8 *buf, int len) PCI_ABI;
> >  int pci_write_byte(struct pci_dev *, int pos, u8 data) PCI_ABI;
> >  int pci_write_word(struct pci_dev *, int pos, u16 data) PCI_ABI;
> >  int pci_write_long(struct pci_dev *, int pos, u32 data) PCI_ABI;
> 
> This has to be properly versioned in order to avoid breaking ABI
> compatibility. See how pci_find_cap() got added in my current development
> tree.

I don't understand how a new function breaks ABI compatibility, but I'll
add it to libpci.ver under LIBPCI_3.1 if that's what you want.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux