On Monday, October 27, 2008 1:26 pm Allan, Bruce W wrote: > >> This PCI quirk is put in ./drivers/net/e1000e in order to share > >> defines and structs found in the driver source, and is only applicable > >> to ICHx GbE LOMs supported by that driver anyway. > > > >Seems to be it is not difficult to put it into drivers/pci/quirks.c, > >where it belongs. > > > > Jeff > > Yes, it wouldn't be difficult to put it elsewhere but does it really belong > in drivers/pci/quirks.c? The quirk is applicable only to the GbE LOM found > on Intel ICH8/9/10-based platforms so one could argue it should be in > arch-specific code (arch/x86/pci/fixup.c). OTOH, quirks in driver > directories are not unprecedented (e.g. drivers/clocksource/acpi_pm.c, > drivers/usb/host/pci-quirks.c). I patched it into the driver's directory > as it would be an obvious reminder when adding support for future parts to > check whether the quirk is applicable and update the list of devices > accordingly. > > So, what is the "right" place? If you think it's likely to apply to future devices as well, I'd say you may as well keep it in the driver. Jesse -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
