Re: [PATCH] [PCI] move ICHx GbE NVM write-protection from e1000e to PCI quirk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Kirsher wrote:
On Fri, Oct 24, 2008 at 6:13 PM, Jeff Kirsher
<jeffrey.t.kirsher@xxxxxxxxx> wrote:
From: Bruce Allan <bruce.w.allan@xxxxxxxxx>

The write-protection method being in the driver probe routine is called
late in the boot sequence, and not at all if the driver is never loaded.
By making it a PCI quirk the NVM is protected much earlier whether or not
the driver is loaded.  The write-protection quirk can be disabled with a
new kernel parameter in the unlikely event the NVM needs to be modified.

Signed-off-by: Bruce Allan <bruce.w.allan@xxxxxxxxx>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
---

 Documentation/kernel-parameters.txt |    4 +
 drivers/net/Makefile                |    1
 drivers/net/e1000e/Makefile         |    1
 drivers/net/e1000e/e1000.h          |    1
 drivers/net/e1000e/ethtool.c        |    6 +
 drivers/net/e1000e/ich8lan.c        |   93 +++-----------------
 drivers/net/e1000e/ich8lan.h        |   68 +++++++++++++++
 drivers/net/e1000e/netdev.c         |    4 -
 drivers/net/e1000e/param.c          |   30 ------
 drivers/net/e1000e/quirks.c         |  162 +++++++++++++++++++++++++++++++++++
 10 files changed, 256 insertions(+), 114 deletions(-)
 create mode 100644 drivers/net/e1000e/ich8lan.h
 create mode 100644 drivers/net/e1000e/quirks.c



This PCI quirk is put in ./drivers/net/e1000e in order to share
defines and structs found in the driver source, and is only applicable
to ICHx GbE LOMs supported by that driver anyway.

Seems to be it is not difficult to put it into drivers/pci/quirks.c, where it belongs.

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux