On Friday, October 3, 2008 3:50 pm Vincent Legoll wrote: > On Fri, Oct 3, 2008 at 8:57 PM, Bjorn Helgaas <bjorn.helgaas@xxxxxx> wrote: > > It'll be easier for Jesse if you include the proper changelog again > > with just a 1-2 line sample of the changed messages. BTW, the "--" > > before your sig confused my mailer into not quoting the patch itself, > > hence the screwed up formatting below. > > The "-- " line is the start-of-.sig marker have I been taught in my > school days, I think they then spoke about netiquette... > > > dev_info() is exactly equivalent to dev_printk(KERN_INFO). I usually > > use dev_info(), though I'm a bit ambivalent because it's nice to be > > able to grep for "printk". > > I left dev_printk(KERN_INFO, ...) for grepability > > > Anyway, maybe you can correct the grammar > > of "enabled forcedly" to something like "you can enable with ..." when > > you re-post with the changelog. > > I've used "You can enable it back with", hoping the gramar is right > > > (Note that dev_dbg() is NOT exactly equivalent to dev_printk(KERN_DEBUG), > > so you can't change all of them. dev_printk(KERN_DEBUG) is always > > compiled in, while dev_dbg() is only compiled in when "DEBUG" is > > defined.) > > Thanks for the hint, for I may have jumped the gun on those "other" > cleanups ;-) > > So here is the new version cut'n'pasted from git-format-patch Can you respin against linux-next and send me a fresh copy? This one seems to have been corrupted somehow (sorry for the slow reply, it's been sitting in my 'to apply' mbox for awhile now). Thanks, Jesse -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
