Re: [PATCH] driver/isdn/hisax/telespci.c: Fix compile time warning.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 06, 2008 at 08:51:30PM +0600, Rakib Mullick wrote:
> On 10/6/08, Matthew Wilcox <matthew@xxxxxx> wrote:
> > On Sun, Oct 05, 2008 at 11:57:48PM -0600, Grant Grundler wrote:
> >  > In general, if the proposed patch makes it better, I personally respond
> >  > better when the maintainer takes that patch and then solicits for
> >  > additional patches.
> >
> >
> > The patch doesn't make things better.
>  Actually the patch was made to fix a warning and to change the
> 'find_pci_device'
> function ( as it is suggested by greg). I think its worth rework .

These drivers will become obsolete in few next kernel versions (replaced by
mISDN).

So I would agree to change find_pci_device to pci_get_device, if this blocks
the remove of find_pci_device, but changing the drivers to full support
the PCI hotplug architecture would need to change implemented scripts and
interfaces in all distros supporting I4L, which must be done a second time
for the change to mISDN, I think we should avoid this double work.

-- 
Karsten Keil
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux