Re: [PATCH] driver/isdn/hisax/telespci.c: Fix compile time warning.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 04, 2008 at 09:59:51AM +0200, Rolf Eike Beer wrote:
> Rakib Mullick wrote:
> > Hello, this patch removes the following warning. Also removes the use of
> >  function 'pci_find_device'.
> >
> > CC      drivers/isdn/hisax/telespci.o
> > drivers/isdn/hisax/telespci.c: In function `setup_telespci':
> > drivers/isdn/hisax/telespci.c:303: warning: `pci_find_device' is
> > deprecated (declared at include/linux/pci.h:537)
> >
> > If anything else please notice. Thanks.
> 
> This driver needs to be converted to proper PCI device API, it looks
> very much like 2.4 code.

Rolf,
Unless someone has worked on 2.4 kernels before and knows what those APIs
are, they won't have a clue what you meant. Can you give Rakib some
examples of obsolete functions or point at specific Documentation/ ?

In general, if the proposed patch makes it better, I personally respond
better when the maintainer takes that patch and then solicits for
additional patches.

hth,
grant

> 
> Greetings,
> 
> Eike


--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux