Re: [PATCH] pciutils: spell Signaled for MSI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matthew Wilcox wrote:
> On Sun, Oct 05, 2008 at 07:24:42PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>>
>> Spell "Signaled" like the PCI SIG spells it (not Signalled).
> 
> Can I propose an alternative patch?  I don't have a problem with
> Randy's, but since we already use "MSI-X" for that capability, maybe we
> should use "MSI" for this one?  It brings that line back down below 80
> columns, which is nice.
> 
> I further wonder if we want to report 'Enable' and 'Mask' in the same
> order ... and 'Count' certainly seems like a better name than 'TabSize'.
> 
> ----
> 
> From: Matthew Wilcox <willy@xxxxxxxxxxxxxxx>
> 
> Change the spelling of 'Signalled' to 'Signaled' to match the PCI spec.
> Report the capability as 'MSI' instead of either 'Message Signaled
> Interrupts' to fit better with MSI-X and bring the width of this line
> below 80 columns.
> 
> Inspired-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Signed-off-by: Matthew Wilcox <willy@xxxxxxxxxxxxxxx>

I certainly have no problem with this change.  Thanks.

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux