On Mon, Oct 06, 2008 at 08:51:30PM +0600, Rakib Mullick wrote: > On 10/6/08, Matthew Wilcox <matthew@xxxxxx> wrote: > > The patch doesn't make things better. > Actually the patch was made to fix a warning and to change the > 'find_pci_device' > function ( as it is suggested by greg). I think its worth rework . > Isn't it maintainer's > responsibility ? You're papering over the problem. You actually introduced a refcounting bug with your patch (there was no pci_dev_put() in the module unload path). But that's irrelevant because the driver should instead be converted to the pci_driver model (see Documentation/PCI/pci.txt). And that conversion should be carried out by someone who can test the driver in question. Do you have the hardware to test this? -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
