Re: [RFC] use pci_find_ext_capability everywhere

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 03, 2008 at 09:24:46AM -0700, Jesse Barnes wrote:
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -1567,9 +1567,8 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct 
> pci_device_id *id)
>  			goto probe_out;
>  	}
>  
> -	if (pci_find_aer_capability(pdev))
> -		if (pci_enable_pcie_error_reporting(pdev))
> -			goto probe_out;
> +	if (!pci_enable_pcie_error_reporting(pdev))
> +		printk(KERN_INFO "qla2xxx: Enabled error reporting\n");
>  
>  	host = scsi_host_alloc(sht, sizeof(scsi_qla_host_t));
>  	if (host == NULL) {

Do we have to add another printk?  If we do, can we at least make it a
dev_info().

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux